Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 10, 2025

  • Extend test schema / dataset with RetailCalendar
  • add tests for RetailCalendar
  • edit fixtures/excludes/etc
  • update snapshots

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon force-pushed the chore/tests-calendar-timeshifts branch from c39ec61 to 7bdb05f Compare July 10, 2025 14:30
@KSDaemon KSDaemon force-pushed the chore/tests-calendar-timeshifts branch from 7bdb05f to d361a61 Compare July 10, 2025 16:48
@KSDaemon KSDaemon marked this pull request as ready for review July 10, 2025 18:31
@KSDaemon KSDaemon requested a review from a team as a code owner July 10, 2025 18:31
@KSDaemon KSDaemon merged commit 7b15732 into master Jul 10, 2025
128 of 131 checks passed
@KSDaemon KSDaemon deleted the chore/tests-calendar-timeshifts branch July 10, 2025 19:07
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
cube-js#9770)

* Extend test schema / dataset with RetailCalendar

* add tests for RetailCalendar

* edit fixtures/excludes/etc

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants